HDDS-9556. Recon UI : Bucket Drop down filter is not getting disabled when more than 1 volume is selected#5503
Merged
dombizita merged 2 commits intoapache:masterfrom Oct 30, 2023
Merged
Conversation
…ot getting disabled when more than 1 volume is selected
devmadhuu
reviewed
Oct 27, 2023
| const isBucketSelectionDisabled = !selectedVolumes || | ||
| (selectedVolumes && | ||
| (selectedVolumes.length > 2 && | ||
| (selectedVolumes.length >= 2 && |
Contributor
There was a problem hiding this comment.
@smitajoshi12 thanks for the patch, however this could be more readable for any developer to easily understand if you could use the condition >1
Contributor
Author
There was a problem hiding this comment.
@devmadhuu
Hi Devesh Done changes in recent commit as per suggestion.
smitajoshi12
changed the title
… when more than 1 volume is selected
dombizita
approved these changes
Oct 30, 2023
Contributor
dombizita
left a comment
dombizita
left a comment
There was a problem hiding this comment.
Thanks for fixing this @smitajoshi12, it looks good to me!
Contributor
|
Thanks for working on this @smitajoshi12, thanks @devmadhuu for the review! |
ibrusentsev
pushed a commit
to ibrusentsev/ozone
that referenced
this pull request
Nov 14, 2023
… when more than 1 volume is selected (apache#5503)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
[Recon][UI] On File Size Insights Page
Bucket Drop down filter is not getting disabled when more than 1 volume is selected
As discussed, bucket drop down filter works only for 1 volume and can't be used if more than 1 volume are present.
When 2 volumes are selected the Bucket list drop down is not getting disabled, whereas on selecting 3 volumes it is getting disabled.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9556
How was this patch tested?
Manually
Before this Change Bucket dropdown is not disabled.
After this PR change Bucket Drop Down is Disabled
