HDDS-8196. DB listener to only track SSTs that belong to the tables of interest.#5511
Merged
hemantk-12 merged 3 commits intoapache:masterfrom Nov 16, 2023
Merged
HDDS-8196. DB listener to only track SSTs that belong to the tables of interest.#5511hemantk-12 merged 3 commits intoapache:masterfrom
hemantk-12 merged 3 commits intoapache:masterfrom
Conversation
aswinshakil
reviewed
Oct 30, 2023
...ksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java
Show resolved
Hide resolved
...ksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java
Show resolved
Hide resolved
prashantpogde
approved these changes
Nov 10, 2023
Contributor
prashantpogde
left a comment
prashantpogde
left a comment
There was a problem hiding this comment.
Rest looks good to me.
swamirishi
requested changes
Nov 10, 2023
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
Thanks for the patch @hemantk-12. There are a lot of changes done, we can simplify the PR to just check compactionJobInfo.columnFamily() is part of the tablelist
...ksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java
Show resolved
Hide resolved
...ksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java
Outdated
Show resolved
Hide resolved
...ksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java
Outdated
Show resolved
Hide resolved
...ksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java
Show resolved
Hide resolved
hemantk-12
force-pushed
the
HDDS-8196
branch
2 times, most recently
from
b4adef6 to
eed40e4
Compare
hemantk-12
force-pushed
the
HDDS-8196
branch
from
eed40e4 to
a0752c9
Compare
swamirishi
approved these changes
Nov 16, 2023
Contributor
swamirishi
left a comment
swamirishi
left a comment
There was a problem hiding this comment.
Thanks for the patch @hemantk-12 LGTM
...ksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java
Show resolved
Hide resolved
| return true; | ||
| } | ||
|
|
||
| if (new HashSet<>(inputFiles).equals(new HashSet<>(outputFiles))) { |
Contributor
Author
There was a problem hiding this comment.
Yes, it is. We have seen bug caused by this and it was going into infinite loop due to self arc.
Contributor
Author
|
Thanks for the review @swamirishi @prashantpogde @aswinshakil |
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Dec 3, 2025
…the tables of interest. (apache#5511) (cherry picked from commit 2ed9f44)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, we track all the column families's compaction in DAG even though we don't need to track everything.
As part of this change, only
keyTable,directoryTableandfileTablecolumn family's compaction is tracked in DAG and corresponding SST files are hard-linked in SST back-up dir. Context: #3981 (comment)What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8196
How was this patch tested?
Added new unit and integration tests.