HDDS-9611. Avoid unnecessary buffer conversion.#5542
Merged
adoroszlai merged 4 commits intoapache:masterfrom Nov 6, 2023
Merged
HDDS-9611. Avoid unnecessary buffer conversion.#5542adoroszlai merged 4 commits intoapache:masterfrom
adoroszlai merged 4 commits intoapache:masterfrom
Conversation
szetszwo
changed the title
adoroszlai
reviewed
Nov 4, 2023
| final ByteBuffer[] buffers = BufferUtils.assignByteBuffers(len, | ||
| bufferCapacity); | ||
| readMethod.accept(buffers); | ||
| return ChunkBuffer.wrap(Lists.newArrayList(buffers)); |
Contributor
There was a problem hiding this comment.
ChunkBuffer doesn't change the list's size, and it creates a defensive copy anyway. So I think we could use Arrays.asList() here.
Contributor
Author
|
@adoroszlai , Thanks for reviewing this! Sync'ed with the master branch and using |
adoroszlai
approved these changes
Nov 6, 2023
Contributor
Author
|
@adoroszlai , thanks for merging this! |
ibrusentsev
pushed a commit
to ibrusentsev/ozone
that referenced
this pull request
Nov 14, 2023
…idateChunkChecksumData (apache#5542)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In KeyValueHandler.validateChunkChecksumData(..), it converts ChunkBuffer to ByteString, which will be converted back to ChunkBuffer.
Also includes code cleanup:
long;All the changes were discovered in HDDS-9536.
What is the link to the Apache JIRA
HDDS-9611
How was this patch tested?
Updating existing tests.