HDDS-9593. Replication Manager: Do not count unique origin nodes as over-replicated#5592
Merged
siddhantsangwan merged 1 commit intoapache:masterfrom Nov 27, 2023
Merged
Conversation
Contributor
siddhantsangwan
left a comment
siddhantsangwan
left a comment
There was a problem hiding this comment.
Idea looks good, I have one comment below.
...va/org/apache/hadoop/hdds/scm/container/replication/health/RatisReplicationCheckHandler.java
Show resolved
Hide resolved
siddhantsangwan
approved these changes
Nov 27, 2023
Contributor
siddhantsangwan
left a comment
siddhantsangwan
left a comment
There was a problem hiding this comment.
LGTM, @sodonnel thanks for the PR.
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Feb 1, 2024
…n nodes as over-replicated (apache#5592) (cherry picked from commit 7dcae67) Change-Id: Ic0c25ec75916a66974f356d0c509dfd4414dbbe5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If a quasi closed container has replicas that are hosted by nodes with unique origins, then don't count them as over replicated because they're all needed.
This change is replicating the change to the Legacy Replication Manager made in HDDS-9489
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9593
How was this patch tested?
New unit tests added