HDDS-9659. Intermittent failure in TestOzoneECClient#testPartialStripeWithPartialChunkRetry#5601
Merged
adoroszlai merged 1 commit intoapache:masterfrom Nov 15, 2023
Merged
Conversation
…eWithPartialChunkRetry
aswinshakil
approved these changes
Nov 14, 2023
Member
aswinshakil
left a comment
There was a problem hiding this comment.
Thanks for the patch @adoroszlai. LGTM
Contributor
Author
|
Thanks @aswinshakil for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix intermittent failures in
testPartialStripeWithPartialChunkRetry:and
and
ECBlockOutputStreambefore exposing it viablockOutputStreammember variable.ConcurrentModificationExceptioninMockXceiverClientFactoryby changing to concurrent set/map.https://issues.apache.org/jira/browse/HDDS-9659
How was this patch tested?
Passed 100x:
https://github.com/adoroszlai/ozone/actions/runs/6862777705
and 250x:
https://github.com/adoroszlai/ozone/actions/runs/6863403759
For reference, failed 2/100 without the fix:
https://github.com/adoroszlai/ozone/actions/runs/6873776049/job/18695127972