HDDS-9697. ContainerStateMachine.applyTransaction(..) should not validate token again.#5622
Merged
adoroszlai merged 6 commits intoapache:masterfrom Nov 19, 2023
Merged
HDDS-9697. ContainerStateMachine.applyTransaction(..) should not validate token again.#5622adoroszlai merged 6 commits intoapache:masterfrom
adoroszlai merged 6 commits intoapache:masterfrom
Conversation
adoroszlai
approved these changes
Nov 19, 2023
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @szetszwo for the patch.
Contributor
Author
|
@adoroszlai , thanks a lot for reviewing and merging this! |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Feb 1, 2024
…uld not validate token again. (apache#5622) (cherry picked from commit 086e303) Conflicts: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestHddsDispatcher.java Change-Id: I33ac8fd48ae3474e946dbfa23003f83c55291c4a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In ContainerStateMachine, the startTransaction(..) method has already validated the token. The applyTransaction(..) should not validate the same token again.
A problem is that the token may expire later on. Then, a server may not be able to re-apply the same transaction when replaying the RaftLog after server restart.
What is the link to the Apache JIRA
HDDS-9697
How was this patch tested?
New unit test.