HDDS-9739. Reduce native build thread count.#5657
Closed
aryangupta1998 wants to merge 1 commit intoapache:masterfrom
Closed
HDDS-9739. Reduce native build thread count.#5657aryangupta1998 wants to merge 1 commit intoapache:masterfrom
aryangupta1998 wants to merge 1 commit intoapache:masterfrom
Conversation
adoroszlai
reviewed
Nov 22, 2023
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
@aryangupta1998 thread count can be overridden by passing -Dsystem.numCores=<N> to the build (since #5552). What is the rationale for removing that ability and hard-coding thread count to 4?
Contributor
|
@aryangupta1998 , shall we close this PR since it can be done by -Dsystem.numCores= now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reducing native build thread count to lower memory usage.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9739
How was this patch tested?
Tested Manually.