Skip to content

HDDS-9691. Migrate remaining tests in ozone-recon to JUnit5#5669

Merged
adoroszlai merged 8 commits intoapache:masterfrom
raju-balpande:raju-b-hdds-9691
Nov 27, 2023
Merged

HDDS-9691. Migrate remaining tests in ozone-recon to JUnit5#5669
adoroszlai merged 8 commits intoapache:masterfrom
raju-balpande:raju-b-hdds-9691

Conversation

@raju-balpande
Copy link
Contributor

@raju-balpande raju-balpande commented Nov 24, 2023

What changes were proposed in this pull request?

Migrate the following test classes to JUnit5.

Please describe your PR in detail:
Migrate the following test classes to JUnit5.

hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/TestReconUtils.java
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/spi/impl/TestOzoneManagerServiceProviderImpl.java
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/common/CommonUtils.java
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/OMMetadataManagerTestUtils.java
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/persistence/TestReconWithDifferentSqlDBs.java
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/scm/TestReconNodeManager.java
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/spi/impl/TestReconDBProvider.java
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/tasks/TestNSSummaryTask.java
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/tasks/TestNSSummaryTaskWithFSO.java
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/tasks/TestNSSummaryTaskWithLegacy.java

Covered two more files which were not in scope.
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/OMMetadataManagerTestUtils.java
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/spi/impl/TestReconDBProvider.java

Also covered to close the Closable using try () block at three places. where it was been closed in catch at two places and was missed to close at one place.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9691

How was this patch tested?

Tested each test cases manually.

@raju-balpande raju-balpande marked this pull request as ready for review November 24, 2023 15:23
@adoroszlai
Copy link
Contributor

Thanks @raju-balpande for the patch. TestReconUtils was changed recently on master (037014d). Please update the new test case added in that commit to fix the build failure:

[ERROR] hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/TestReconUtils.java:[218,5] cannot find symbol
  symbol:   variable Assert
  location: class org.apache.hadoop.ozone.recon.TestReconUtils

https://github.com/raju-balpande/apache_ozone/actions/runs/6982357699/job/19001367610#step:6:2678

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raju-balpande for the patch.

@adoroszlai adoroszlai merged commit aeb5040 into apache:master Nov 27, 2023
@adoroszlai
Copy link
Contributor

Thanks @raju-balpande for updating the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants