HDDS-9769. SCM's FinalizationStateManager#finalizeLayoutFeature Ratis call should be idempotent.#5670
Merged
nandakumar131 merged 2 commits intoapache:masterfrom Nov 28, 2023
Merged
Conversation
… call should be idempotent.
Contributor
|
@errose28 would you like to take a look? |
errose28
reviewed
Nov 27, 2023
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
LGTM just one suggestion on the log message.
...-hdds/common/src/main/java/org/apache/hadoop/ozone/upgrade/AbstractLayoutVersionManager.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks @sumitagrawl @errose28 for the review. |
Contributor
|
Thanks for the quick fix @nandakumar131 |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Feb 1, 2024
…eature Ratis call should be idempotent. (apache#5670) (cherry picked from commit ae58db3) Change-Id: I6cd8e569c7889e8b18d505eb339eafcccd58e308
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If there is a restart during or immediately after SCM upgrade finalization, the
FinalizationStateManager#finalizeLayoutFeatureRatis call will be re-executed while Raft log is re-applied during restart.This will cause the SCM to crash if
FinalizationStateManager#finalizeLayoutFeaturecall is not idempotent.This PR modifies the behaviour of
AbstractLayoutVersionManagerto makefinalizeLayoutFeaturecall idempotent.What is the link to the Apache JIRA
HDDS-9769
How was this patch tested?
Modified the existing unit test to verify the new behavior.