HDDS-9772. Avoid recreating typesafe config objects unnecessarily#5690
Merged
adoroszlai merged 3 commits intoapache:masterfrom Nov 30, 2023
Merged
HDDS-9772. Avoid recreating typesafe config objects unnecessarily#5690adoroszlai merged 3 commits intoapache:masterfrom
adoroszlai merged 3 commits intoapache:masterfrom
Conversation
Contributor
|
@adoroszlai Thanks, work on this, That's a good idea, LGTM. |
guohao-rosicky
approved these changes
Nov 30, 2023
Contributor
Author
|
Thanks @guohao-rosicky for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
XceiverServerRatiscreatesDatanodeRatisServerConfigrepeatedly for accessing individual properties. It should create it only once and reuse.Some other similar usage patterns are also fixed.
Ideally we should strive to pass these objects from fewer places, but that change would affect many classes, and cause conflict in other tasks in-progress. Hence this change is limited in scope.
https://issues.apache.org/jira/browse/HDDS-9772
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7019067260