HDDS-9801. Increase the timeout in TestPipelineClose#testPipelineCloseWithPipelineAction.#5702
Merged
nandakumar131 merged 1 commit intoapache:masterfrom Nov 29, 2023
Merged
Conversation
…eWithPipelineAction.
sodonnel
approved these changes
Nov 29, 2023
Contributor
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
LGTM - lets commit if CI is green as this problem is breaking most other CI runs.
Contributor
|
Failed in 139/250 runs for 2cbb0e6 (HDDS-9479). Passed in 250/250 runs for 28fa30c (the commit before HDDS-9479). Runs with the fix from this PR are still in progress. |
Contributor
|
Passed 500/500 with the fix. |
Contributor
Author
|
Thanks @adoroszlai for testing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
TestPipelineClose#testPipelineCloseWithPipelineActiononly waits for 5 seconds before it timeout and fails.The
ozone.scm.pipeline.destroy.timeoutis set to 5 seconds in the test. So, SCM will send close pipeline command to Datanode only after 5 seconds and the datanode is not getting enough time to remove the pipeline.It's good to increase the max wait time in test to at least 10 seconds.
What is the link to the Apache JIRA
HDDS-9801
How was this patch tested?
Executed the test multiple times in local to make sure that the test consistently passes.