HDDS-9805. Reduce cluster size in integration tests.#5706
Merged
szetszwo merged 1 commit intoapache:masterfrom Dec 7, 2023
Merged
HDDS-9805. Reduce cluster size in integration tests.#5706szetszwo merged 1 commit intoapache:masterfrom
szetszwo merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
Contributor
Contributor
tanvipenumudy
left a comment
tanvipenumudy
left a comment
There was a problem hiding this comment.
Thank you @ArafatKhan2198, the changes look good to me.
I think we can also reduce the cluster size for a few more tests under the package org.apache.hadoop.ozone.client.rpc as needed, such as:
- TestWatchForCommit
- TestOzoneAtRestEncryption
- TestFailureHandlingByClientFlushDelay
- TestFailureHandlingByClient
Contributor
|
thanks @ArafatKhan2198 for the change, and maybe update these following tests as well:
Thanks! |
szetszwo
approved these changes
Dec 7, 2023
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Let's merge this first so that the tests can pass easier and run faster. We could work on the other tests separately.
Contributor
|
@tanvipenumudy, @DaveTeng0 , thanks a lot for reviewing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The following tests seem to create too many datanode and pipelines. We can change it to 5 datanodes and 3 pipelines. This will reduce the setup time and with fewer
datanodesandpipelines, there's less likelihood of encountering resource contention and timing issues. Such issues can often lead to intermittent failures that are hard to reproduce and diagnose.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9805
How was this patch tested?
All the tests ran successfully.
https://github.com/ArafatKhan2198/ozone/actions/runs/7045478194