HDDS-9762. Fix dfs s3a protocol for FSO bucket.#5735
Merged
ChenSammi merged 2 commits intoapache:masterfrom Dec 7, 2023
Merged
HDDS-9762. Fix dfs s3a protocol for FSO bucket.#5735ChenSammi merged 2 commits intoapache:masterfrom
ChenSammi merged 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@ChenSammi @sadanand48 @tanvipenumudy Can you please take a look. |
Contributor
|
I did manual tests as well, and I can confirm that these changes fix FileAlreadyExistsException for https://issues.apache.org/jira/browse/HDDS-9762. Thank you @ashishkumar50 for working on this! |
Contributor
tanvipenumudy
left a comment
tanvipenumudy
left a comment
There was a problem hiding this comment.
Thank you @ashishkumar50, the changes look good to me.
ChenSammi
approved these changes
Dec 7, 2023
Contributor
ChenSammi
left a comment
ChenSammi
left a comment
There was a problem hiding this comment.
Thanks @ashishkumar50 for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There are two problem which is handled in this PR
OzoneBucketasstartKeydoesn't accept NULL value, which impacts LightWeight ListKeys API (Using Lightweight API introduced in HDDS-8773).But in case if key not found case also, it should return normal response with 0 keycount to s3api.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9762
How was this patch tested?
Manually verified