HDDS-9849. Improve UUID generator and get rid of java-uuid-generator dependency#5740
Merged
adoroszlai merged 2 commits intoapache:masterfrom Dec 7, 2023
Merged
Conversation
szetszwo
approved these changes
Dec 6, 2023
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
@vtutrinov , thanks for promptly working on this! Some code becomes unused. Let's remove them?
hadoop-hdds/common/src/main/java/org/apache/hadoop/util/UUIDUtil.java
Outdated
Show resolved
Hide resolved
szetszwo
approved these changes
Dec 7, 2023
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
|
Thanks @vtutrinov for the patch, @szetszwo for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Provide a method to get generated UUID as a bytes array and get rid of the fasterxml:java-uuid-generator dependency
Please describe your PR in detail:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9849
How was this patch tested?
manually