HDDS-9365. [hsync] DataNode to deserialize Ratis transaction only once. #5752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like the PR fails the acceptance tests consecutively. @szetszwo can you check again? |
Contributor
Author
|
The test failures were due to the context is not created in follower. Just have updated the code to see if it can pass the tests. |
Contributor
Author
|
@jojochuang , it can pass the tests now. Please take a look again. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Today DataNode deserializes request proto at every callback method: applyTransaction, applyTransaction, writeTransaction, readTransaction.
For a transaction, the deserialzation happens more than 5 times (readTransaction happens twice for leader)
It's super expensive. We should deserialize only once during preAppendTransaction() which takes place in parallel.
What is the link to the Apache JIRA
HDDS-9365
How was this patch tested?
Existing unit tests.