HDDS-9885. Checkstyle check passing despite config error

[adoroszlai]

What changes were proposed in this pull request?

basic (checkstyle) is shown as passing if it fails with config error, not a checkstyle violation.

https://issues.apache.org/jira/browse/HDDS-9885

How was this patch tested?

Verified that the check fails with 9b16de3 checked out (which had the config error):

$ hadoop-ozone/dev-support/checks/checkstyle.sh > /dev/null

$ hadoop-ozone/dev-support/checks/_summary.sh target/checkstyle/summary.txt
13:58:11,624 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (default-cli) on project ozone-main: Failed during checkstyle configuration: cannot initialize module TreeWalker - TreeWalker is not allowed as a parent of LineLength Please review 'Parent Module' section for this Check in web documentation if Check is standard. -> [Help 1]

$ echo $?
1

Verified the check still fails if there is checkstyle violation:

$ hadoop-ozone/dev-support/checks/checkstyle.sh > /dev/null

$ hadoop-ozone/dev-support/checks/_summary.sh target/checkstyle/summary.txt
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
 91: Line is longer than 80 characters (found 82).
 92: Line is longer than 80 characters (found 81).

$ echo $?
1

Verified the check still passes with code conforming to checkstyle rules:

$ hadoop-ozone/dev-support/checks/checkstyle.sh > /dev/null

$ hadoop-ozone/dev-support/checks/_summary.sh target/checkstyle/summary.txt

$ echo $?
0

CI:
https://github.com/adoroszlai/ozone/actions/runs/7158011023/job/19489560474

[kerneltime]

why not inside the if condition?

[adoroszlai]

Previously it was in the else branch, not the if (as only the first mvn execution was redirected to output.log). With this change, both executions are redirected, so we'd need to cat in both if and else. Which can be simplified by moving this common step after the if.

[adoroszlai]

Thanks @kerneltime for reviewing and merging this.