HDDS-9896. Fix for NullPointerException when replicating closed container using freon#5765
Merged
jojochuang merged 2 commits intoapache:masterfrom Dec 12, 2023
Merged
HDDS-9896. Fix for NullPointerException when replicating closed container using freon#5765jojochuang merged 2 commits intoapache:masterfrom
jojochuang merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
cc @DaveTeng0 |
jojochuang
approved these changes
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We are seeing NPE when replicating closed container using freon
This change is to fix NPE and pass non-null
volumeSetwhen creatingContainerImporterobject to replicate closed container using freon. Also added @NotNull annotation on ContainerImporter's constructor for developers.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9896
How was this patch tested?
Existing unit and integ tests for now.