HDDS-9975. Add static import for assertions and mocks in hdds-server-framework#5849
Merged
adoroszlai merged 4 commits intoapache:masterfrom Dec 22, 2023
Merged
HDDS-9975. Add static import for assertions and mocks in hdds-server-framework#5849adoroszlai merged 4 commits intoapache:masterfrom
adoroszlai merged 4 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Dec 21, 2023
Contributor
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @wzhallright for the patch.
Can you please also include:
hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/TestTypedRDBTableStore.java?
Otherwise LGTM.
Contributor
Author
Thanks for you detailed review @adoroszlai .I missed it, it was my fault, and include it now. Thanks again. |
Contributor
|
Just two more items here: |
Contributor
Author
@adoroszlai fixed comments,thanks for review. |
adoroszlai
reviewed
Dec 22, 2023
Contributor
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @wzhallright for the patch. Let's not import Arguments.of, otherwise LGTM.
...dds/framework/src/test/java/org/apache/hadoop/hdds/security/symmetric/TestLocalKeyStore.java
Outdated
Show resolved
Hide resolved
adoroszlai
approved these changes
Dec 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The goal of this task is to add import static for all assertions and interactions with mocks. Replacing:
and
and
makes the code more readable (shorter lines, less wrapping).
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9975
CI
https://github.com/wzhallright/ozone/actions/runs/7286857379