HDDS-9982. Improve assertTrue assertions in hdds-server-framework

[wzhallright]

What changes were proposed in this pull request?

Improve assertTrue assertions in hadoop-hdds/framework
Assertions in the form:

assertTrue(<string>.contains(...))

do not provide any information about the actual value, if the assertion fails.

AssertionFailedError: expected: <true> but was: <false>

This can be improved by replacing them with:

import static org.assertj.core.api.Assertions.assertThat;
assertThat(<string>).contains(...)

which gives us more info in the form:

AssertionError: 

Expecting:
 <"actual string">
to contain:
 <"part"> 

Similarly, assertions about inequality relations, e.g.:

assertTrue(<x> > <y>)

can be replaced with:

assertThat(<x>).isGreaterThan(<y>);

The goal of this task is to find and replace such assertTrue assertions.

What is the link to the Apache JIRA

HDDS-9982

CI

https://github.com/wzhallright/ozone/actions/runs/7318537019

[adoroszlai]

Thanks @wzhallright for working on this.

[adoroszlai]

assertFalse assertions can be changed along the same lines:

assertThat(result).doesNotContain(entry.getKey());

Sorry if that wasn't clear from the task description. I have now updated the parent issue.

[wzhallright]

fixed

[adoroszlai]

With assertTrue(..., message), the second parameter was only passed to get some useful hint in case of failure. When using assertThat, we get such hint automatically, so we can omit withFailMessage(message).

[wzhallright]

Do we need to omit all waitFailMessage or allow the user to partially customize useful messages?
Because there is still some user-defined information in the current PR

[adoroszlai]

I'd remove two kinds:

• where the string itself is passed (like here)
• message similar to "expected: ..., got: ..."

We can keep the rest.

[adoroszlai]

Here the "not equal" value is changed from 0 to 1. Why?

[wzhallright]

fixed

[adoroszlai]

I think withFailMessage can be omitted here, too.

[wzhallright]

fixed

[adoroszlai]

nit: keeping .contains... on new line makes the assertion more readable, because assertThat's argument is also a chained method call

[wzhallright]

fixed

[adoroszlai]

This one can also be converted to assertThat.

[wzhallright]

fixed

[adoroszlai]

Thanks @wzhallright for the patch.