HDDS-10036. OzoneManagerRatisServer.getServer() should return Division.#5892
Merged
adoroszlai merged 2 commits intoapache:masterfrom Jan 1, 2024
Merged
HDDS-10036. OzoneManagerRatisServer.getServer() should return Division.#5892adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Dec 31, 2023
| .next().getUuid().toString(); | ||
| final RaftServer.Division server = om.getOmRatisServer().getServerDivision(); | ||
| final String ratisDir = server.getRaftServer().getProperties().get("raft.server.storage.dir"); | ||
| final String groupIdDirName = server.getGroup().getGroupId().toString(); |
Contributor
There was a problem hiding this comment.
TestOzoneManagerPrepare is failing due to mismatch in the directory name.
Suggested change
| final String groupIdDirName = server.getGroup().getGroupId().toString(); | |
| final String groupIdDirName = server.getGroup().getGroupId().getUuid().toString(); |
Contributor
Author
There was a problem hiding this comment.
That is a good catch! Thanks for the tip.
adoroszlai
approved these changes
Jan 1, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @szetszwo for the improvement.
Contributor
Author
|
@adoroszlai , thanks a lot for reviewing and merging this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
OzoneManagerRatisServerhas a specific raftGroup. ThegetServer()method should return the division specific to that group. Otherwise, callers have to get groupId and then get the division with try-catch.What is the link to the Apache JIRA
HDDS-10036
How was this patch tested?
By updating existing tests.