HDDS-10039. Remove the flushLatches set from FlushNotifier.#5900
Merged
adoroszlai merged 2 commits intoapache:masterfrom Jan 10, 2024
Merged
HDDS-10039. Remove the flushLatches set from FlushNotifier.#5900adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
Contributor
@smengcl I'm on vacation and won't have time to look at this till I get back, (in 2 weeks.) |
Contributor
Author
|
@smengcl , could you review this then? |
Contributor
smengcl
reviewed
Jan 9, 2024
...e/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java
Show resolved
Hide resolved
...e/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java
Show resolved
Hide resolved
...e/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java
Outdated
Show resolved
Hide resolved
...e/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java
Show resolved
Hide resolved
Contributor
Author
|
@smengcl , thanks a lot for reviewing this! Just have pushed a commit addressing your comment. |
Contributor
Contributor
Author
|
@smengcl , thanks for reviewing this! @adoroszlai , thanks for merging this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
FlushNotifier, it add a new latch to theflushLatchesset for eachawait()call.We may reduce the number of objects by using
CompletableFuture. Then, theawait()calls waiting for the same flush will use for the same future.What is the link to the Apache JIRA
HDDS-10039
How was this patch tested?
By updating existing tests.