HDDS-10058. Replace Hamcrest assertions#5919
Merged
adoroszlai merged 1 commit intoapache:masterfrom Jan 5, 2024
Merged
Conversation
hemantk-12
approved these changes
Jan 4, 2024
Contributor
hemantk-12
left a comment
hemantk-12
left a comment
There was a problem hiding this comment.
Thanks for the patch @adoroszlai .
LGTM+1.
kerneltime
reviewed
Jan 4, 2024
| <dependency> | ||
| <groupId>org.hamcrest</groupId> | ||
| <artifactId>hamcrest-all</artifactId> | ||
| <artifactId>hamcrest-core</artifactId> |
Contributor
There was a problem hiding this comment.
Can we try to get rid of core as well?
Contributor
Author
There was a problem hiding this comment.
Sure, let me try that.
Contributor
Author
There was a problem hiding this comment.
Yes, we can remove hamcrest-core, but only because we also have hamcrest as a transitive dependency.
Contributor
Author
|
Thanks @hemantk-12, @kerneltime for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace Hamcrest
assertThatand matchers with JUnit or AssertJ assertions, to reduce the number of test dependencies a bit.https://issues.apache.org/jira/browse/HDDS-10058
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7409626572