HDDS-10063. NumKeys metric not decremented on FSO directory delete.#5933
Merged
adoroszlai merged 4 commits intoapache:masterfrom Jan 8, 2024
Merged
HDDS-10063. NumKeys metric not decremented on FSO directory delete.#5933adoroszlai merged 4 commits intoapache:masterfrom
adoroszlai merged 4 commits intoapache:masterfrom
Conversation
See HDDS-10078
Contributor
|
Thanks @errose28 for the patch, @dombizita for the review. |
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Jun 10, 2024
…ry delete. (apache#5933) (cherry picked from commit 7a2bd38) Conflicts: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmMetrics.java This change also migrates TestOmMetrics to Junit5 using changes from HDDS-9775 for that class only. Change-Id: I9edf0d493431deb1df66fd7f023633ebcd48e208
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Directory and file count is included in the OM NumKeys metric. When a directory is deleted from OM, its subdirectories and files are not subtracted from the current key count held by the NumKeys metric. We can decrement this metric in the OMDirectoriesPurgeRequestWithFSO sent out by the leader's directory deleting service so that the metric is updated asynchronously on the leader and all followers.
What is the link to the Apache JIRA
HDDS-10063
How was this patch tested?
New integration test for directory related metrics added to the existing test class for OM Metrics.