HDDS-10084. Replace LEGACY in integration test with default layout from config#5940
Merged
errose28 merged 3 commits intoapache:masterfrom Jan 8, 2024
Merged
HDDS-10084. Replace LEGACY in integration test with default layout from config#5940errose28 merged 3 commits intoapache:masterfrom
errose28 merged 3 commits intoapache:masterfrom
Conversation
Contributor
errose28
reviewed
Jan 8, 2024
Contributor
There was a problem hiding this comment.
Thanks @adoroszlai. Functionally LGTM. Maybe we want to add comments to that refer to the Jira(s) to fix the tests that are manually specifying LEGACY layout?
errose28
approved these changes
Jan 8, 2024
Contributor
Author
|
Thanks @errose28 for reviewing and merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace hard-coded
BucketLayout.LEGACYwith the configured default bucket layout:ozone/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestDataUtil.java
Lines 142 to 145 in 48ea0bb
and similarly here:
ozone/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestDataUtil.java
Lines 52 to 55 in 48ea0bb
Keep using
LEGACYin two tests that fail with the defaultFILE_SYSTEM_OPTIMIZEDlayout.https://issues.apache.org/jira/browse/HDDS-10084
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7440054515