HDDS-10094. OM start failure due to failure to parse OM metrics file.#5971
Closed
sadanand48 wants to merge 1 commit intoapache:masterfrom
Closed
HDDS-10094. OM start failure due to failure to parse OM metrics file.#5971sadanand48 wants to merge 1 commit intoapache:masterfrom
sadanand48 wants to merge 1 commit intoapache:masterfrom
Conversation
| metrics.setNumKeys(metricsInfo.getNumKeys()); | ||
| } else { | ||
| metrics.setNumKeys(metadataManager.countEstimatedRowsInTable( | ||
| metadataManager.getKeyTable(BucketLayout.LEGACY))); |
Contributor
There was a problem hiding this comment.
Can we have getBucketLayout() instead of passing BucketLayout.LEGACY?
Contributor
|
Thanks for looking at this issue @sadanand48. @dombizita and I were actually discussing this area and I have summarized our thoughts in HDDS-10110. Basically I think we should get rid of the OM metrics file and use the RocksDB key count estimates to maintain estimates of these metrics between restarts. |
Contributor
|
I have a draft PR of the above proposal in #5988 |
Contributor
Author
|
Thanks @errose28 for letting me know, I will close this PR in that case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add exception handling around failure to read the omMetrics file .
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10094
How was this patch tested?
Manual fix