HDDS-10018. Fix search function don't show on the first page about Node Status for SCM webUI

[aierate]

What changes were proposed in this pull request?

Fix search function don't show on the first page about Node Status for SCM webUI

Please describe your PR in detail:

In the Node Status column of SCM's webUI, when I searched for datanode, the detailed information of the datanode was not displayed on the first page, so I fixed it. After fixing, perform a search operation and the detailed information of the datanode will be displayed on the first page.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10018

How was this patch tested?

This is a screenshot of the fixed version:

when I search conway-hadoop4：

[aierate]

Please help me review the code, thanks.

[ArafatKhan2198]

Thank you for addressing this, @aierate. Could you provide further clarification on the issue you're encountering? Are you attempting to implement a search functionality for the Node Status table, or are you resolving an existing issue with it?

The logic for handling the search in this table is present in the scm-overview.html file at :-

ozone/hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html

Line 64 in 74f04a7

<tr ng-repeat="typestat in nodeStatus|filter:search|orderBy:columnName:reverse">

How it works :-

When the user types something into the search input, AngularJS updates the value of $scope.search.
The filter:search part of the ng-repeat directive then filters the items in the nodeStatus array based on the value of $scope.search, showing only those items that match the search criteria. The items are then displayed in the table row () according to the filtering applied.

I checked it with the upsteream master build and the search works fine.

[aierate]

Thank you for addressing this, @aierate. Could you provide further clarification on the issue you're encountering? Are you attempting to implement a search functionality for the Node Status table, or are you resolving an existing issue with it?

The logic for handling the search in this table is present in the scm-overview.html file at :-

ozone/hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html

Line 64 in 74f04a7

<tr ng-repeat="typestat in nodeStatus|filter:search|orderBy:columnName:reverse">

How it works :-

When the user types something into the search input, AngularJS updates the value of $scope.search. The filter:search part of the ng-repeat directive then filters the items in the nodeStatus array based on the value of $scope.search, showing only those items that match the search criteria. The items are then displayed in the table row () according to the filtering applied.

I checked it with the upsteream master build and the search works fine.

Thanks @ArafatKhan2198 . When the number of DataNodes exceeds one page, if you search for DataNodes on the second page, the search results will be displayed on the second page.

[ArafatKhan2198]

@aierate, thank you for clarifying. It seems that the search function only works for the records currently displayed on the page, which indeed is a bug. I appreciate you bringing this to our attention. The approach looks sound overall; however, I do have a few suggestions that you can consider.

[ArafatKhan2198]

Thanks for the changes @aierate
LGTM +1

[ArafatKhan2198]

@adoroszlai could you take a look as well!

[smitajoshi12]

@muskan1012
Can you also review this PR

[smitajoshi12]

Looks good to me.

[aierate]

Can this PR be merged, please？

[dombizita]

Thanks for working on this @aierate! Sorry for the late review and thanks for pinging us on the PR. I checked out you changes, built it and locally tried it with docker. I created a cluster with 15 datanodes and checked the SCM UI. Without the search everything looked good.

• I searched for "1"

• The "Next" button was clickable, I clicked on it.

• I was able to go back with the "Previous" button

Could you look into this? It should have show me the 7 seven datanodes with "1" in their names, I shouldn't have been able to go to the next page. It's also unexpected that when I came back to the first page again, I saw 6th datanode in the list, but not the 2 datanodes that were visible on the second page.

[ArafatKhan2198]

@aierate Could you please take a look at the comments and fix them if necessary.

[aierate]

@aierate Could you please take a look at the comments and fix them if necessary.

Thanks @ArafatKhan2198 @dombizita. I will try to fix these issues later. Thank you for your suggestions

[adoroszlai]

@aierate would you like to continue work on this?

[adoroszlai]

/pending will try to fix these issues later

[github-actions]

Marking this issue as un-mergeable as requested.

Please use /ready comment when it's resolved.

Please note that the PR will be closed after 21 days of inactivity from now. (But can be re-opened anytime later...)

will try to fix these issues later

[github-actions]

Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author.

It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.

It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.

If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel."