HDDS-10187. Update hdds-interface-client proto.lock for 1.4#6074
Merged
errose28 merged 2 commits intoapache:ozone-1.4from Jan 23, 2024
Merged
HDDS-10187. Update hdds-interface-client proto.lock for 1.4#6074errose28 merged 2 commits intoapache:ozone-1.4from
errose28 merged 2 commits intoapache:ozone-1.4from
Conversation
Contributor
|
@adoroszlai Thank you for the fix. LGTM. |
symious
approved these changes
Jan 23, 2024
errose28
approved these changes
Jan 23, 2024
Contributor
errose28
left a comment
There was a problem hiding this comment.
LGTM thanks for doing the detective work on this @adoroszlai
Contributor
Author
adoroszlai
added a commit
to adoroszlai/ozone
that referenced
this pull request
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Some
proto.lockfiles were not updated for the 1.4.0 release. This happened because the new v0.17.0 version ofprotolockintroduced a new check, which is failing forDatanodeClientProtocol.protoandcsi.proto:This PR updates
proto.lockfiles:--forceoption, done separately for easier reviewhttps://issues.apache.org/jira/browse/HDDS-10187
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7622797005