HDDS-10278. Simplify tests using assertDoesNotThrow#6291
Merged
adoroszlai merged 4 commits intoapache:masterfrom Feb 28, 2024
Merged
HDDS-10278. Simplify tests using assertDoesNotThrow#6291adoroszlai merged 4 commits intoapache:masterfrom
adoroszlai merged 4 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Feb 28, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @wzhallright for the patch. Mostly looks good, some minor improvements suggested.
hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/TestRDBTableStore.java
Outdated
Show resolved
Hide resolved
hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/TestTypedRDBTableStore.java
Outdated
Show resolved
Hide resolved
...ation-test/src/test/java/org/apache/hadoop/fs/ozone/TestDirectoryDeletingServiceWithFSO.java
Show resolved
Hide resolved
...op-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedDDSWithFSO.java
Show resolved
Hide resolved
...e/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestSnapshotDeletingService.java
Show resolved
Hide resolved
...tion-test/src/test/java/org/apache/hadoop/ozone/om/TestSnapshotDirectoryCleaningService.java
Show resolved
Hide resolved
...e/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/service/TestKeyDeletingService.java
Show resolved
Hide resolved
adoroszlai
reviewed
Feb 28, 2024
...ation-test/src/test/java/org/apache/hadoop/fs/ozone/TestDirectoryDeletingServiceWithFSO.java
Outdated
Show resolved
Hide resolved
adoroszlai
approved these changes
Feb 28, 2024
Contributor
|
Thanks @wzhallright for the patch. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Mar 15, 2024
(cherry picked from commit 4095ef1) Change-Id: I47a27c2e87dc9d36e735103bc0ed8fcd63903e32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Simplify tests using assertDoesNotThrow
Please describe your PR in detail:
try-catch-fail can be changed to:
if the test does not have any assertions other than the fail() call being removed. (See HDDS-10277 for even more simpler solution if the test has other assertions.)
What is the link to the Apache JIRA
HDDS-10278
CI
https://github.com/wzhallright/ozone/actions/runs/8076086411