HDDS-10041. Do not start the daemon inside the OzoneManagerDoubleBuffer constructor.#6300
Merged
szetszwo merged 2 commits intoapache:masterfrom Mar 1, 2024
Merged
HDDS-10041. Do not start the daemon inside the OzoneManagerDoubleBuffer constructor.#6300szetszwo merged 2 commits intoapache:masterfrom
szetszwo merged 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@smengcl , thanks for reviewing this! It turned out that the test failures were related. Just pushed a commit for fixing them. |
Contributor
Author
|
@smengcl , thanks for reviewing this! |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Mar 15, 2024
…er constructor. (apache#6300) (cherry picked from commit 11fddc4) Change-Id: I5d11f70ce7e36475dc1ad5736ec6c782b178f9b5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It is generally a bad practice to start a thread inside a constructor; see https://stackoverflow.com/questions/11834173/why-shouldnt-i-use-thread-start-in-the-constructor-of-my-class
Also, quite a few tests (such as
TestOzoneManagerDoubleBuffer) has to stop the daemon in order to eliminate the race condition in the very beginning.What is the link to the Apache JIRA
HDDS-10041
How was this patch tested?
Updating existing tests.