HDDS-10472. Audit log should include EC replication config#6338
Merged
adoroszlai merged 2 commits intoapache:masterfrom Mar 6, 2024
Merged
HDDS-10472. Audit log should include EC replication config#6338adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
tanvipenumudy
approved these changes
Mar 6, 2024
Contributor
tanvipenumudy
left a comment
There was a problem hiding this comment.
Thanks for the patch @adoroszlai, LGTM
sodonnel
approved these changes
Mar 6, 2024
Contributor
Author
|
Thanks @sodonnel, @tanvipenumudy for the review. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Mar 15, 2024
(cherry picked from commit 309e459) Change-Id: I0bd39d42cdf6222752c8d12cff12fc2e9487cc23
myskov
pushed a commit
to myskov/ozone
that referenced
this pull request
Apr 3, 2024
(cherry picked from commit 309e459)
myskov
pushed a commit
to myskov/ozone
that referenced
this pull request
Apr 3, 2024
(cherry picked from commit 309e459)
myskov
pushed a commit
to myskov/ozone
that referenced
this pull request
Apr 3, 2024
(cherry picked from commit 309e459)
myskov
pushed a commit
to myskov/ozone
that referenced
this pull request
Apr 4, 2024
(cherry picked from commit 309e459)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Audit log for key creation is missing information about EC replication (see
replicationFactor=ZERO).https://issues.apache.org/jira/browse/HDDS-10472
How was this patch tested?
Verified OM audit log for EC key creation in acceptance tests:
Log for Ratis keys is unchanged:
https://github.com/adoroszlai/ozone/actions/runs/8170275505