HDDS-10556. Checkstyle summary excludes errors with xml#6410
Merged
myskov merged 1 commit intoapache:masterfrom Mar 22, 2024
Merged
HDDS-10556. Checkstyle summary excludes errors with xml#6410myskov merged 1 commit intoapache:masterfrom
myskov merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you @adoroszlai for the patch LGTM+1 |
myskov
approved these changes
Mar 22, 2024
Contributor
myskov
left a comment
There was a problem hiding this comment.
thanks for the patch @adoroszlai , LGTM
Contributor
Author
|
Thanks @myskov for reviewing and merging this. |
smitajoshi12
pushed a commit
to smitajoshi12/ozone
that referenced
this pull request
Mar 27, 2024
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
(cherry picked from commit 74f04a7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
summary.txtfor checkstyle incorrectly removes failure message that matches the stringxml, e.g. unused import fromcom.fasterxml.jackson.checkstyle-errors.xml:summary.txt:The problem is that
<\?xmlmatches<xmlorxmlinstead of<?xmlas intended.https://issues.apache.org/jira/browse/HDDS-10556
How was this patch tested?
Checked out ArafatKhan2198@9d4b3e5, ran checkstyle: