HDDS-10597. Use MutableGauge for threshold based SafeModeMetrics.#6446
Merged
aryangupta1998 merged 2 commits intoapache:masterfrom Apr 2, 2024
Merged
HDDS-10597. Use MutableGauge for threshold based SafeModeMetrics.#6446aryangupta1998 merged 2 commits intoapache:masterfrom
aryangupta1998 merged 2 commits intoapache:masterfrom
Conversation
sadanand48
changed the title
aryangupta1998
approved these changes
Apr 2, 2024
Contributor
aryangupta1998
left a comment
aryangupta1998
left a comment
There was a problem hiding this comment.
Thanks @sadanand48 for the patch, LGTM +1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Right now, we use MutableCounterLong for threshold metrics like
numContainerWithOneReplicaReportedThresholdand when it is updated insetNumContainerWithOneReplicaReportedThreshold(long val)it incremented instead of setting the accurate value. This makes no sense as this field is a threshold and shouldn't be used as a counter.The JMX output shows cumulative addition of these threshold values which makes no sense
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10597
How was this patch tested?
Manually