HDDS-10628. Display if safemode exit was via force exit command.#6494
Merged
adoroszlai merged 4 commits intoapache:masterfrom Apr 24, 2024
Merged
HDDS-10628. Display if safemode exit was via force exit command.#6494adoroszlai merged 4 commits intoapache:masterfrom
adoroszlai merged 4 commits intoapache:masterfrom
Conversation
sadanand48
changed the title
myskov
requested changes
Apr 8, 2024
Contributor
myskov
left a comment
myskov
left a comment
There was a problem hiding this comment.
Thanks @sadanand48 for the patch. Just a minor comment from me.
...op-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/SCMSafeModeManager.java
Outdated
Show resolved
Hide resolved
Contributor
|
cc @Tejaskriya |
ayushtkn
reviewed
Apr 17, 2024
Comment on lines
326
to
328
| public boolean isSafeModeExitForceful() { | ||
| return forceExitSafeMode.get(); | ||
| } |
Member
There was a problem hiding this comment.
the name of the variable is forceExitSafeMode the setter is also setForceExitSafeMode can we keep this method name in line: isForceExitSafeMode()
Contributor
|
Thanks @sadanand48 for the patch, @ayushtkn, @myskov, @sumitagrawl, @Tejaskriya for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Safe mode rules are not calculated/updated after a safemode force exit, If a user looks at the SCM web UI after a force exit , it would give an impression that SCM is in safemode by looking at the rules not being satisfied.
Displaying if safe mode was forcefully exited will be helpful in this case.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10628
How was this patch tested?
Manually
