HDDS-10745. Do not use BitSet for OzoneAcl.aclBitSet.

[szetszwo]

What changes were proposed in this pull request?

The BitSet class used by aclBitSet is inefficient. We have to copy it in order to make aclBitSet immutable. BitSet is also inefficient in memory usage.

What is the link to the Apache JIRA

HDDS-10745

How was this patch tested?

Existing unit tests.

[adoroszlai]

Thanks @szetszwo for the patch.

[adoroszlai]

To fix test failure:

Suggested change

	public List<String> getAclStringList() {
	return getAclList(aclBits, ACLType::name);
	@JsonIgnore
	public List<String> getAclStringList() {
	return getAclList(aclBits, ACLType::name);

[adoroszlai]

I suggest moving these to OzoneAcl and making them private. This would make it easier to completely get rid of BitSet in the future by reducing the public interface.

[adoroszlai]

Thanks @szetszwo for updating the patch.

The new Proto2Utils class could be useful for other sub-modules, so I suggest putting it in hadoop-hdds/common instead of hadoop-ozone/common.

[adoroszlai]

} is missing from EOF.

[szetszwo]

@adoroszlai , thanks for reviewing this! That's a good suggestion. Let move it to hadoop-hdds/common.

[adoroszlai]

Looks like failure in TestOzoneDebugShell is related:

2024-04-25 15:58:50,480 [DBScanner-0] ERROR debug.DBScanner (DBScanner.java:call(516)) - Exception parse Object
com.fasterxml.jackson.databind.JsonMappingException: Document nesting depth (1001) exceeds the maximum allowed (1000, from `StreamWriteConstraints.getMaxNestingDepth()`) (through reference chain: java.util.ArrayList[0]->org.apache.hadoop.ozone.OzoneAcl["toStringMethod"]->org.apache.ratis.util.MemoizedSupplier["initializer"]->org.apache.hadoop.ozone.OzoneAcl$$Lambda$832/0x00007f47105fdd68["arg$1"]->org.apache.hadoop.ozone.OzoneAcl["toStringMethod"]-...)
	at com.fasterxml.jackson.databind.JsonMappingException.wrapWithPath(JsonMappingException.java:402)
	at com.fasterxml.jackson.databind.JsonMappingException.wrapWithPath(JsonMappingException.java:361)
	at com.fasterxml.jackson.databind.ser.std.StdSerializer.wrapAndThrow(StdSerializer.java:323)
	at com.fasterxml.jackson.databind.ser.std.BeanSerializerBase.serializeFields(BeanSerializerBase.java:778)
	at com.fasterxml.jackson.databind.ser.BeanSerializer.serialize(BeanSerializer.java:183)

I think we need @JsonIgnore for the two new supplier fields:

ozone/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.java

Lines 67 to 68 in 37cba81

	private final Supplier<String> toStringMethod;
	private final Supplier<Integer> hashCodeMethod;