HDDS-10753. OmKeyInfo#acls and WithMetadata#metadata are not thread safe. #6591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
approved these changes
Apr 26, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @szetszwo for the patch.
Contributor
Author
|
@adoroszlai , thanks a lot for reviewing and merging this! |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
…afe. (apache#6591) (cherry picked from commit 32b1692)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
@xichen01 pointed out in #6518 (comment) that OMKeyInfo#copyObject is just a shallow copy. It is not thread safe since OmKeyInfo#acls is just an ArrayList.
Similarly, WithMetadata#metadata is also not thread safe.
In this PR, we replace
ArrayListandHashMapand withCopyOnWriteArrayListandConcurrentHashMap, respectively.What is the link to the Apache JIRA
HDDS-10753
How was this patch tested?
Existing tests.