HDDS-10796. Avoid dummy KeyOutputStream in OzoneOutputStreamStub#6623
Merged
adoroszlai merged 1 commit intoapache:masterfrom May 3, 2024
Merged
HDDS-10796. Avoid dummy KeyOutputStream in OzoneOutputStreamStub#6623adoroszlai merged 1 commit intoapache:masterfrom
adoroszlai merged 1 commit intoapache:masterfrom
Conversation
ivandika3
approved these changes
May 3, 2024
Contributor
ivandika3
left a comment
ivandika3
left a comment
There was a problem hiding this comment.
Thanks @adoroszlai for the improvement. LGTM +1.
Contributor
Author
|
Thanks @ivandika3 for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
OzoneOutputStreamStub.getKeyOutputStream()returns a dummyKeyOutputStream, which has no relation to the underlying stream (the one passed to parentOzoneOutputStreamclass).This PR eliminates the need for the dummy
KeyOutputStream. The only caller (ObjectEndpoint) can access it viaOzoneOutputStream, so the stub's custom logic is not bypassed.https://issues.apache.org/jira/browse/HDDS-10796
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/8928970232