HDDS-10793. HttpFS gateway should throw unsupported operation for some operations#6645
Merged
fapifta merged 2 commits intoapache:masterfrom May 6, 2024
Merged
HDDS-10793. HttpFS gateway should throw unsupported operation for some operations#6645fapifta merged 2 commits intoapache:masterfrom
fapifta merged 2 commits intoapache:masterfrom
Conversation
…exception Change-Id: I0bbb7f722b405d5fa2ecf7c841f43082e55286c3
Change-Id: I354d0bbb1d2476e07c9d2ca2b1e0be3ee1ba265e
fapifta
approved these changes
May 6, 2024
Contributor
fapifta
left a comment
fapifta
left a comment
There was a problem hiding this comment.
Thank you for bringing this up @dombizita, +1.
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
…e operations (apache#6645) (cherry picked from commit db2e507)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We didn't have and still don't have support for home directory or trash root in Ozone. The default Filesystem implementation has these implemented, so we had that behaviour in Ozone too, but this can lead to confusion (eg. the home "directory" is actually a bucket under the specific
uservolume, as we returned/user/username).With this change we'll throw unsupported operation exception for the
GETHOMEDIRECTORYand theGETTRASHROOToperations. I also removed the test cases for these operations. The Ozone HttpFS documentation already stated, that these operations are unsupported, so I didn't need to change that.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10793
How was this patch tested?
CI: https://github.com/dombizita/ozone/actions/runs/8968724724