HDDS-11005. TestEndPoint#testRegisterRpcTimeout fails when run in itself#6806
Merged
tanvipenumudy merged 3 commits intoapache:masterfrom Jun 13, 2024
Merged
HDDS-11005. TestEndPoint#testRegisterRpcTimeout fails when run in itself#6806tanvipenumudy merged 3 commits intoapache:masterfrom
tanvipenumudy merged 3 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Jun 12, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @Tejaskriya for finding this issue and working on it.
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/ozone/container/common/TestEndPoint.java
Outdated
Show resolved
Hide resolved
adoroszlai
approved these changes
Jun 13, 2024
tanvipenumudy
approved these changes
Jun 13, 2024
Contributor
There was a problem hiding this comment.
Thank you @Tejaskriya for updating the patch, LGTM!
Thank you @adoroszlai for the review!
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After running the testRegisterRpcTimeout through the flaky workflow: https://github.com/Tejaskriya/ozone/actions/runs/9476838761 , the test seems to fail each time.
Even when the single test case is run multiple times locally, failures are observed on the first run, and the remaining runs are successful.
By seeing the logs, It seems like the steps after timeout interruption takes place could take 700-800ms when the test is run individually.
In this PR, the test is refactored to measure only the required latency of endpointTask.call(), and not the remaining steps.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11005
How was this patch tested?
Tested flaky workflow: https://github.com/Tejaskriya/ozone/actions/runs/9494208563