HDDS-10942. OM decommission config support for default serviceID.#6834
Merged
sadanand48 merged 3 commits intoapache:masterfrom Jun 19, 2024
Merged
HDDS-10942. OM decommission config support for default serviceID.#6834sadanand48 merged 3 commits intoapache:masterfrom
sadanand48 merged 3 commits intoapache:masterfrom
Conversation
sadanand48
reviewed
Jun 19, 2024
sadanand48
reviewed
Jun 19, 2024
Contributor
sadanand48
left a comment
sadanand48
left a comment
There was a problem hiding this comment.
Thanks @aryangupta1998 for the patch , LGTM, pending green CI
sadanand48
approved these changes
Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, before we decommission an OM, Ozone needs to configure with "ozone.om.decommissioned.nodes.serviceID" to vary of OM's to be decommissioned.
It would be nice to add a constant suffix-less config key support i.e. if only one serviceId is configured, "ozone.om.decommissioned.nodes" should be an acceptable config key that defaults to the only configured ID.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10942
How was this patch tested?
Tested Manually + Unit tests