HDDS-11030. Do not throw OperatorCreationException from CertificateApprover#sign#6843
Merged
dombizita merged 2 commits intoapache:masterfrom Jun 26, 2024
Merged
HDDS-11030. Do not throw OperatorCreationException from CertificateApprover#sign#6843dombizita merged 2 commits intoapache:masterfrom
dombizita merged 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Thank you for the review @dombizita pending CI on conflict resolution. |
Contributor
Contributor
Author
|
Thank you for the reviews and merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The CertificateApprover interface is using OperatorCreationException from BouncyCastle as a signed exception thrown from DefaultApprover#sign method. In order to clean this BouncyCastle class from the generic interface, I removed it from the checked exceptions on the interface, and wrapped it into a generic CertificateException at DefaultApprover.
This is part of the effort to shrink down direct BouncyCastle dependencies to the minimum before moving things to the crypto modules.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11030
How was this patch tested?
This is a fairly simple change, we do not have tests testing for this particular exception to be thrown though. I am reluctant to create one as of now, as this code has to be moved around, and we are planning to review the tests when the actual move is done.