Skip to content

HDDS-11059. Reduce OM DEBUG messages#6861

Merged
tanvipenumudy merged 1 commit intoapache:masterfrom
sarvekshayr:HDDS-11059
Jun 27, 2024
Merged

HDDS-11059. Reduce OM DEBUG messages#6861
tanvipenumudy merged 1 commit intoapache:masterfrom
sarvekshayr:HDDS-11059

Conversation

@sarvekshayr
Copy link
Contributor

@sarvekshayr sarvekshayr commented Jun 25, 2024

What changes were proposed in this pull request?

When DEBUG logging is enabled for OM, there are many un-useful messages as mentioned in the JIRA description. These messages are now in TRACE log level.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11059

How was this patch tested?

Tested the patch on docker.
Before changing the log level:

2024-06-27 07:56:36 2024-06-27 02:26:36 INFO  OzoneManager:1228 - Creating RPC Server
2024-06-27 07:56:36 2024-06-27 02:26:36 DEBUG RocksDatabase:684 - get: size=-1, remaining=4096
2024-06-27 07:56:36 2024-06-27 02:26:36 INFO  RaftServer$Division:256 - om1: new RaftServerImpl for group-C5BA1605619E:[om1|om:9872] with OzoneManagerStateMachine:uninitialized
2024-06-27 07:56:36 2024-06-27 02:26:36 DEBUG LifeCycle:154 - om1: NEW

After changing the log level:

2024-06-27 08:00:29 2024-06-27 02:30:29 INFO  OzoneManager:1228 - Creating RPC Server
2024-06-27 08:00:29 2024-06-27 02:30:29 INFO  RaftServer$Division:256 - om1: new RaftServerImpl for group-C5BA1605619E:[om1|om:9872] with OzoneManagerStateMachine:uninitialized
2024-06-27 08:00:29 2024-06-27 02:30:29 DEBUG LifeCycle:154 - om1: NEW

When TRACE log level is enabled, we can see this line in the output:

2024-06-27 07:52:42 2024-06-27 02:22:42 INFO  OzoneManager:1228 - Creating RPC Server
2024-06-27 07:52:42 2024-06-27 02:22:42 TRACE SecurityUtil:577 - Name lookup for om took 0 ms.
2024-06-27 07:52:42 2024-06-27 02:22:42 TRACE RocksDatabase:684 - get: size=-1, remaining=4096
2024-06-27 07:52:42 2024-06-27 02:22:42 INFO  RaftServer$Division:256 - om1: new RaftServerImpl for group-C5BA1605619E:[om1|om:9872] with OzoneManagerStateMachine:uninitialized
2024-06-27 07:52:42 2024-06-27 02:22:42 DEBUG LifeCycle:154 - om1: NEW

Copy link
Contributor

@tanvipenumudy tanvipenumudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sarvekshayr for the patch. Could you please share the output log messages from before vs after implementing the change?

@tanvipenumudy tanvipenumudy requested a review from szetszwo June 25, 2024 08:11
@sarvekshayr
Copy link
Contributor Author

Thank you @sarvekshayr for the patch. Could you please share the output log messages from before vs after implementing the change?

I've shared the output screenshots now.

@adoroszlai
Copy link
Contributor

I've shared the output screenshots now.

Please share logs text as text, not screenshots. Plain text makes it easier to

  • read (especially for those with visual impairments)
  • reference (e.g. quote)
  • search

It also reduces size to be stored by GitHub.

(Not relevant for now, but sharing code can be even better by using permalink URLs.)

Copy link
Contributor

@tanvipenumudy tanvipenumudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, thanks.

@sarvekshayr
Copy link
Contributor Author

Please share logs text as text, not screenshots.

Updated and shared the logs as text. Thank you for pointing this out @adoroszlai

@tanvipenumudy tanvipenumudy changed the title HDDS-11059. Reduce OM DEBUG message HDDS-11059. Reduce OM DEBUG messages Jun 27, 2024
@tanvipenumudy
Copy link
Contributor

Thank you @sarvekshayr for the patch, thank you @adoroszlai for the review.

@tanvipenumudy tanvipenumudy merged commit edc8c19 into apache:master Jun 27, 2024
@szetszwo
Copy link
Contributor

@sarvekshayr , thanks a lot for working on this!

@tanvipenumudy , thanks for reviewing and merging this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants