HDDS-11113. Remove unused ScmUtils#preCheck and related code#6907
Merged
adoroszlai merged 2 commits intoapache:masterfrom Jul 9, 2024
Merged
HDDS-11113. Remove unused ScmUtils#preCheck and related code#6907adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
myskov
added
the
code-cleanup
adoroszlai
reviewed
Jul 8, 2024
Comment on lines
-49
to
-50
| if (inSafeMode.get() && SafeModeRestrictedOps | ||
| .isRestrictedInSafeMode(op)) { |
Contributor
There was a problem hiding this comment.
SafeModeRestrictedOps is no longer used either, we can remove hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/SafeModeRestrictedOps.java
adoroszlai
approved these changes
Jul 8, 2024
adoroszlai
changed the title
Contributor
|
Thanks @myskov for the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removed dead code:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11113
How was this patch tested?
existing test suite