HDDS-11168. [hsync] Instantiates audit parameter lazily in DataNode dispatch handler#6933
Merged
jojochuang merged 1 commit intoapache:HDDS-7593from Jul 16, 2024
Merged
Conversation
…ispatch handler Change-Id: I0595905b7ac238f38b35a618d499991542f34e1e (cherry picked from commit 8ab92d0864dadf571a2ae6b89b7b7839025980d1)
duongkame
approved these changes
Jul 16, 2024
Contributor
duongkame
left a comment
duongkame
left a comment
There was a problem hiding this comment.
Thanks @jojochuang for the patch. It makes sense to me. +1.
Contributor
Author
|
Thanks @duongkame. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-11168. [hsync] Instantiates audit parameter lazily in DataNode dispatch handler
Please describe your PR in detail:
The profiler flamegraph shows audit parameters are created for every request even when they are not used. It's a small impact but it would be nice to remove the overhead. It is seen inside writeStateMachine() and applyTransaction()
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11168
How was this patch tested?
Existing unit tests. There's no functional change.