HDDS-11174. [hsync] Change XceiverClientRatis.watchForCommit to async.#6941
HDDS-11174. [hsync] Change XceiverClientRatis.watchForCommit to async.#6941jojochuang merged 8 commits intoapache:masterfrom
Conversation
|
@duongkame and @smengcl , I will keep |
|
This PR won't make it into the HDDS-7593 feature branch before the branch gets merged next week. |
jojochuang
left a comment
There was a problem hiding this comment.
LGTM. But the PR has a code conflict, and we're about to merge the feature branch into master, so please rebase against master after the branch is merged into master (should take at most another day).
Thanks!
|
Sure, will fix the conflicts after the merge. |
| public abstract XceiverClientReply watchForCommit(long index) | ||
| throws InterruptedException, ExecutionException, TimeoutException, | ||
| IOException; | ||
| public CompletableFuture<XceiverClientReply> watchForCommit(long index) { |
There was a problem hiding this comment.
Shall we also change this one to watchForCommitAsync without breaking compatibility?
| public XceiverClientReply watchForCommit(long index) | ||
| throws InterruptedException, ExecutionException, TimeoutException, | ||
| IOException { | ||
| public CompletableFuture<XceiverClientReply> watchForCommit(long index) { |
There was a problem hiding this comment.
Shall we change this one to watchForCommitAsync without breaking compatibility?
|
Would you like to take a glance at this @duongkame ? |
|
@jojochuang , @smengcl , thanks for your helps! |
What changes were proposed in this pull request?
In the code below, it should just return the replyFuture instead of calling CompletableFuture.get(). This change is useful for HDDS-9844.
What is the link to the Apache JIRA
HDDS-11174
How was this patch tested?
Updating existing tests.