HDDS-11282. Combine test setup for datanode upgrade unit tests#7063
Merged
adoroszlai merged 5 commits intoapache:masterfrom Aug 15, 2024
Merged
HDDS-11282. Combine test setup for datanode upgrade unit tests#7063adoroszlai merged 5 commits intoapache:masterfrom
adoroszlai merged 5 commits intoapache:masterfrom
Conversation
jojochuang
reviewed
Aug 14, 2024
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
LGTM just a one line change suggestion otherwise all good.
...e/src/test/java/org/apache/hadoop/ozone/container/upgrade/TestDatanodeUpgradeToSchemaV3.java
Outdated
Show resolved
Hide resolved
…ozone/container/upgrade/TestDatanodeUpgradeToSchemaV3.java
Contributor
|
Thanks @chungen0126 for the patch, @jojochuang for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TestDatanodeUpgradeToScmHA was the first unit test for handling of a specific datanode layout version. It works by starting just the minimal SCM RPC server and running datanodes without their heartbeat thread. This allows most fo the functionality that would be present in a MiniOzoneCluster integration test but runs at the speed of a unit test.
The framework has since been adopted for testing other layout features in TestDatanodeUpgradeToSchemaV3 and TestDatanodeUpgradeToHBaseSupport, but the code has been copied each time. This Jira is to extract the common setup code so that it can be re-used to test datanode layout features in the future.
What is the link to the Apache JIRA
HDDS-11282
How was this patch tested?
CI:
https://github.com/chungen0126/ozone/actions/runs/10351405194