HDDS-11865. Remove tests for non-Ratis OM#7535
Conversation
adoroszlai
added
om
code-cleanup
|
Thanks for working on this @adoroszlai. We also have non-ha and om-ha (no scm ha) clusters in the upgrade acceptance suite used for testing older versions. Should we remove those as well? Maybe in a follow up PR if that's easier. |
Thanks for mentioning these. Created HDDS-11902 for the follow-up. |
| } | ||
|
|
||
| @Test | ||
| @Unhealthy("HDDS-11870") |
There was a problem hiding this comment.
this is failing due to open key table not cleaned up properly. Given that it is a flaky test, it sounds to me the issue is probably double flush not flushed. So not a fundamental flaw.
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
Had a quick pass. Just a few comments the rest is good.
| /** | ||
| * Test Ozone Client with OM Ratis enabled. | ||
| */ | ||
| class TestOzoneRpcClientWithRatis extends OzoneRpcClientTests { |
There was a problem hiding this comment.
this is replaced by TestOzoneRpcClient
There was a problem hiding this comment.
Yes, sorry, forgot to mention some "WithRatis" tests were renamed after deleting the non-Ratis counterparts (name without classifier).
| /** | ||
| * Tests the AWS S3 SDK basic operations with OM Ratis enabled. | ||
| */ | ||
| public class TestS3SDKV1WithRatis extends AbstractS3SDKV1Tests { |
There was a problem hiding this comment.
replaced by TestS3SDKV1
| * Tests OM epoch generation for when Ratis is not enabled. | ||
| */ | ||
| @Timeout(240) | ||
| public class TestOMEpochForNonRatis { |
There was a problem hiding this comment.
Is there a similar test when Ratis is enabled? Or is that not relevent?
There was a problem hiding this comment.
I think transaction index comes from Ratis in that case.
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
All tests pass. I think this one is good to go.
|
Thanks @jojochuang for the review. |
3 participants
What changes were proposed in this pull request?
TestOMEpochForNonRatisTestHSyncwhich fails with Ratis OM (should be fixed in HDDS-11870)https://issues.apache.org/jira/browse/HDDS-11865
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/12196695873