HDDS-11992. Replace GenericCli#createOzoneConfiguration calls with getOzoneConf.#7623
Merged
adoroszlai merged 2 commits intoapache:masterfrom Dec 29, 2024
Merged
HDDS-11992. Replace GenericCli#createOzoneConfiguration calls with getOzoneConf.#7623adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
adoroszlai
reviewed
Dec 28, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
GenericCli#getOzoneConfis getting called beforepicocliinjects the command-line OptionsconfigurationOverridesandconfigurationPath, so theOzoneConfigutationobject is created beforepicocliupdates these Options.
Thanks for spotting it. For the record: this happens in execute(String[]) overridden to start tracing.
Comment on lines
57
to
53
| private final Supplier<OzoneConfiguration> configSupplier = | ||
| MemoizedSupplier.valueOf(OzoneConfiguration::new); | ||
| private final CommandLine cmd; | ||
| private OzoneConfiguration conf; |
Contributor
There was a problem hiding this comment.
Since almost all commands use the config, I think we can create the config eagerly:
private final OzoneConfiguration conf = new OzoneConfiguration();
Contributor
Author
There was a problem hiding this comment.
Makes sense. Will update the PR.
adoroszlai
approved these changes
Dec 29, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @nandakumar131 for updating the patch.
Contributor
Author
|
Thanks for the review @adoroszlai! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace
GenericCli#createOzoneConfigurationcalls withGenericCli#getOzoneConf.GenericCli#getOzoneConfis getting called beforepicocliinjects the command-line OptionsconfigurationOverridesandconfigurationPath, so theOzoneConfigutationobject is created beforepicocliupdates these Options.To update the
OzoneConfigutationobject withconfigurationOverridesandconfigurationPath, this PR changes theconfigurationOverridesandconfigurationPathinstance variables to methods.What is the link to the Apache JIRA
HDDS-11992
How was this patch tested?
CI Run: 12523963928