HDDS-11969. getFilechecksum() API fails if checksum type is NONE. #7656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Jan 7, 2025
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/OzoneClientConfig.java
Show resolved
Hide resolved
Contributor
|
Please wait for clean CI run in fork before opening PR. |
added 3 commits
January 8, 2025 12:31
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
adoroszlai
approved these changes
Jan 9, 2025
Contributor
|
Thanks @sadanand48 for the patch, @jojochuang for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Return null when unsupported combine mode is passed and skip checksum compute.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11969
How was this patch tested?
Unit test