Skip to content

Conversation

@devabhishekpal
Copy link
Contributor

What changes were proposed in this pull request?

HDDS-12016. Fixed duplicate entries when changing path in DU page

Please describe your PR in detail:
Previously:

  • The Disk Usage metadata details are not being set properly. We are using an array of keys and an array of values as the data for metadata table from which we generate the table data by mapping.
  • So if we change the path, specially while viewing the quota related details in the table i.e change table page and then change path - rows from second page will be repeated in the new path metadata causing it to be flaky.
  • We made separate calls to the summary and quota APIs and set the state twice. This causes issues with syncing up state as APIs might return in different times.

As a part of this PR:

  • We are going to use an array of objects to avoid recalculation of data we are already having, also we will make sure to remove duplicate entries when the path change triggers metadata table remount.
  • We are changing to simultaneously call both summary and quota APIs and set the state only once per path change.
  • Minor refactor of error checking method from overview page to common utils.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12016

How was this patch tested?

Patch was tested manually.

Screen.Recording.2025-01-07.at.15.00.08.mp4

@devabhishekpal
Copy link
Contributor Author

@devmadhuu @ArafatKhan2198 @dombizita could you help take a look at this PR?

Copy link
Contributor

@devmadhuu devmadhuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devabhishekpal for the patch. Changes LGTM +1

Copy link
Contributor

@ArafatKhan2198 ArafatKhan2198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArafatKhan2198 ArafatKhan2198 merged commit c006c57 into apache:master Jan 19, 2025
36 checks passed
@devabhishekpal devabhishekpal deleted the HDDS-12016 branch January 19, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants