Skip to content

HDDS-12042. Fix capacity count for cluster capacity card.#7666

Merged
dombizita merged 1 commit intoapache:masterfrom
devabhishekpal:HDDS-12042
Jan 14, 2025
Merged

HDDS-12042. Fix capacity count for cluster capacity card.#7666
dombizita merged 1 commit intoapache:masterfrom
devabhishekpal:HDDS-12042

Conversation

@devabhishekpal
Copy link
Contributor

What changes were proposed in this pull request?

HDDS-12042. Fix capacity count for cluster capacity card.

Please describe your PR in detail:

  • In the new vs old UI we have a discrepancy in the details of the cluster capacity card.

  • Mismatch between the Capacity report percentage:

    • In the new UI we are calculating the percentage for the Overview page storage guage chart by choosing the floor value.
    • In the old UI this is done as the rounded value.
    • We are changing the new UI to use the rounded value instead of floor.
  • Mismatch between the Pre-allocated size:

    • In the new UI we are making use of the committed field from the storage report response.
    • In the old UI we are not passing this value to StorageBar component, hence it is picking default value of 0.
    • We should change the old UI to make use of the committed size.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12042

How was this patch tested?

Patch was tested manually
Screenshot 2025-01-08 at 20 02 21
Screenshot 2025-01-08 at 20 02 41

Copy link
Contributor

@ArafatKhan2198 ArafatKhan2198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@dombizita dombizita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @devabhishekpal!

@dombizita dombizita merged commit b024a6b into apache:master Jan 14, 2025
36 checks passed
@dombizita
Copy link
Contributor

Thanks for the patch @devabhishekpal, thanks for the review @ArafatKhan2198!

@devabhishekpal devabhishekpal deleted the HDDS-12042 branch January 14, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants